Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dcl to 1.74.0 #11883

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Upgrade dcl to 1.74.0 #11883

merged 3 commits into from
Oct 1, 2024

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Oct 1, 2024

also made make upgrade-dcl work again after the go rewrite

Release Note Template for Downstream PRs (will be copied)

containeraws: added `kubelet_config` field group to the `google_container_aws_node_pool` resource
assuredworkloads: added `HEALTHCARE_AND_LIFE_SCIENCES_CONTROLS` and `HEALTHCARE_AND_LIFE_SCIENCES_CONTROLS_WITH_US_SUPPORT` enum values to `compliance_regime` in the `google_assuredworkload_workload` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 114 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 6 files changed, 114 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_container_aws_node_pool (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_aws_node_pool" "primary" {
  kubelet_config {
    cpu_cfs_quota        = # value needed
    cpu_cfs_quota_period = # value needed
    cpu_manager_policy   = # value needed
    pod_pids_limit       = # value needed
  }
}

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickElliot's PR in https://github.com/GoogleCloudPlatform/magic-modules/pull/11804/files introduced some samples file changes- I think that's a separate step than make upgrade-dcl. You may want to rebase off of that to include those as well (and we should probably update the update docs somewhere so that everyone is consistent)

@c2thorn
Copy link
Member Author

c2thorn commented Oct 1, 2024

added the samples that were reverted from https://github.com/GoogleCloudPlatform/magic-modules/pull/11804/files

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 135 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 7 files changed, 149 insertions(+), 8 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4124
Passed tests: 3710
Skipped tests: 413
Affected tests: 1

Click here to see the affected service packages

All service packages are affected

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

rileykarson
rileykarson previously approved these changes Oct 1, 2024
Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test seems unrelated.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4124
Passed tests: 3708
Skipped tests: 413
Affected tests: 3

Click here to see the affected service packages

All service packages are affected

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccContainerAwsNodePool_BasicHandWritten
  • TestAccContainerAwsNodePool_BetaBasicHandWritten
  • TestAccDataprocCluster_withAutoscalingPolicy

Get to know how VCR tests work

@rileykarson rileykarson dismissed their stale review October 1, 2024 20:18

waiting on full test run

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccContainerAwsNodePool_BasicHandWritten[Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@c2thorn c2thorn merged commit 1ac0c48 into GoogleCloudPlatform:main Oct 1, 2024
11 of 12 checks passed
@c2thorn c2thorn deleted the upgrade-dcl branch October 1, 2024 20:55
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 4, 2024
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
trodge pushed a commit to trodge/magic-modules that referenced this pull request Oct 10, 2024
karolgorc pushed a commit to karolgorc/magic-modules that referenced this pull request Oct 11, 2024
gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants