-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dcl to 1.74.0 #11883
Upgrade dcl to 1.74.0 #11883
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_container_aws_node_pool" "primary" {
kubelet_config {
cpu_cfs_quota = # value needed
cpu_cfs_quota_period = # value needed
cpu_manager_policy = # value needed
pod_pids_limit = # value needed
}
}
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NickElliot's PR in https://github.com/GoogleCloudPlatform/magic-modules/pull/11804/files introduced some samples file changes- I think that's a separate step than make upgrade-dcl
. You may want to rebase off of that to include those as well (and we should probably update the update docs somewhere so that everyone is consistent)
added the samples that were reverted from https://github.com/GoogleCloudPlatform/magic-modules/pull/11804/files |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 4124 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing test seems unrelated.
Tests analyticsTotal tests: 4124 Click here to see the affected service packages
Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
🟢 Tests passed during RECORDING mode: 🟢 No issues found for passed tests after REPLAYING rerun. 🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
also made
make upgrade-dcl
work again after the go rewriteRelease Note Template for Downstream PRs (will be copied)